Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change: use 9180 as Admin API's port #7806

Merged
merged 1 commit into from
Aug 30, 2022
Merged

change: use 9180 as Admin API's port #7806

merged 1 commit into from
Aug 30, 2022

Conversation

spacewander
Copy link
Member

@spacewander spacewander commented Aug 28, 2022 •
edited
Loading

Signed-off-by: spacewander [email protected]

Description

Fixes #7113

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@spacewander spacewander force-pushed the tam branch 4 times, most recently from 40b0d1c to 8caa126 Compare August 28, 2022 14:22
@spacewander spacewander changed the title change: when deployment mode is traditional, use 9180 as Admin API's port change: use 9180 as Admin API's port Aug 28, 2022
@spacewander spacewander force-pushed the tam branch 6 times, most recently from bc08c86 to edb3887 Compare August 29, 2022 02:08
@spacewander spacewander marked this pull request as ready for review August 29, 2022 03:22
@spacewander spacewander mentioned this pull request Aug 29, 2022
Merged
5 tasks
juzhiyuan
juzhiyuan approved these changes Aug 30, 2022
View reviewed changes
Copy link
Member

@juzhiyuan juzhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a huge change! It's clearer than using the same port. LGTM

@spacewander spacewander merged commit 8b14c68 into apache:master Aug 30, 2022
@spacewander spacewander deleted the tam branch August 30, 2022 09:43
@soulbird soulbird mentioned this pull request Sep 2, 2022
Merged
@tzssangglass tzssangglass mentioned this pull request Sep 15, 2022
Closed
Liu-Junlin pushed a commit to Liu-Junlin/apisix that referenced this pull request Nov 4, 2022
@spacewander @Liu-Junlin
change: use 9180 as Admin API's port (apache#7806)
76aab85
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nic-chen nic-chen nic-chen left review comments

@tzssangglass tzssangglass tzssangglass approved these changes

@juzhiyuan juzhiyuan juzhiyuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: The DP side and the CP side no longer share the same port by default
4 participants
@spacewander @juzhiyuan @tzssangglass @nic-chen