docs: update Chinese opentelemetry docs #7235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SylviaBABY
reviewed
Jun 14, 2022
SylviaBABY
reviewed
Jun 14, 2022
juzhiyuan
reviewed
Jun 14, 2022
| @@ -136,7 +135,7 @@ $ curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335 | |||
| "upstream": { | |||
| "type": "roundrobin", | |||
| "nodes": { | |||
| "10.110.149.175:8089": 1 | |||
| "127.0.0.1:1980": 1 | |||
There was a problem hiding this comment.
😂 For me, as a web developer, I could understand 3000 port is an app port. 1980 is not easy to understand, people will think what's it used for?
There was a problem hiding this comment.
This port is used by upstreams in all plugins, just for consistency.
There was a problem hiding this comment.
😂 For me, as a web developer, I could understand
3000port is an app port.1980is not easy to understand, people will think what's it used for?
Well, I think it’s ok.
SylviaBABY
approved these changes
Jun 14, 2022
juzhiyuan
approved these changes
Jun 16, 2022
spacewander
pushed a commit
that referenced
this pull request
Jun 30, 2022
Liu-Junlin
pushed a commit
to Liu-Junlin/apisix
that referenced
this pull request
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
update Chinese opentelemetry docs. #7086
Checklist