Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Apache OpenWhisk plugin #5518

Merged
merged 64 commits into from
Nov 25, 2021
Merged

feat: add Apache OpenWhisk plugin #5518

merged 64 commits into from
Nov 25, 2021

Conversation

bzp2010
Copy link
Contributor

@bzp2010 bzp2010 commented Nov 15, 2021

What this PR does / why we need it:

Support for Apache OpenWhisk serverless platform.
Implement: #5485

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@bzp2010 bzp2010 added the plugin label Nov 15, 2021
@bzp2010 bzp2010 self-assigned this Nov 15, 2021
@bzp2010 bzp2010 force-pushed the feat-plugin-openwhisk branch 6 times, most recently from 6896677 to 184e5da Compare November 17, 2021 16:32
@bzp2010 bzp2010 linked an issue Nov 18, 2021 that may be closed by this pull request
Proposal: support Apache OpenWhisk serverless framework plugin #5485
Closed
@bzp2010 bzp2010 force-pushed the feat-plugin-openwhisk branch from 43998d8 to c150d15 Compare November 18, 2021 11:21
@bzp2010 bzp2010 marked this pull request as ready for review November 18, 2021 11:40
spacewander
spacewander reviewed Nov 19, 2021
View reviewed changes
t/plugin/openwhisk.t Show resolved Hide resolved
apisix/plugins/openwhisk.lua Show resolved Hide resolved
conf/config-default.yaml Outdated Show resolved Hide resolved
apisix/plugins/openwhisk.lua Outdated Show resolved Hide resolved
apisix/plugins/openwhisk.lua Show resolved Hide resolved
tokers
tokers reviewed Nov 19, 2021
View reviewed changes
apisix/plugins/openwhisk.lua Outdated Show resolved Hide resolved
apisix/plugins/openwhisk.lua Outdated Show resolved Hide resolved
apisix/plugins/openwhisk.lua Show resolved Hide resolved
apisix/plugins/openwhisk.lua Show resolved Hide resolved
@bzp2010 bzp2010 force-pushed the feat-plugin-openwhisk branch from 57f7792 to b20ec70 Compare November 19, 2021 02:12
spacewander
spacewander reviewed Nov 21, 2021
View reviewed changes
apisix/plugins/openwhisk.lua Outdated Show resolved Hide resolved
apisix/plugins/openwhisk.lua Show resolved Hide resolved
docs/en/latest/plugins/openwhisk.md Outdated Show resolved Hide resolved
docs/en/latest/plugins/openwhisk.md Outdated Show resolved Hide resolved
docs/en/latest/plugins/openwhisk.md Outdated Show resolved Hide resolved
apisix/plugins/openwhisk.lua Outdated Show resolved Hide resolved
t/core/request.t Outdated Show resolved Hide resolved
@bzp2010
Copy link
Contributor Author

bzp2010 commented Nov 22, 2021 •
edited
Loading

These change will implement in next PR

Update

Based on a tip from an Apache OpenWhisk community member in #5485 (comment) and more document reading, I found that the current code implementation has some limitations and I will modify part of the implementation.

  • Add packages support
  • Add JSON response parse
  • update test case

cc @spacewander @tokers

@bzp2010 bzp2010 force-pushed the feat-plugin-openwhisk branch from 8084ac6 to 70494f4 Compare November 22, 2021 08:08
membphis
membphis reviewed Nov 22, 2021
View reviewed changes
apisix/core/request.lua Outdated Show resolved Hide resolved
apisix/plugins/openwhisk.lua Show resolved Hide resolved
docs/en/latest/plugins/openwhisk.md Outdated Show resolved Hide resolved
docs/zh/latest/plugins/openwhisk.md Outdated Show resolved Hide resolved
spacewander
spacewander reviewed Nov 23, 2021
View reviewed changes
docs/en/latest/plugins/openwhisk.md Outdated Show resolved Hide resolved
docs/en/latest/plugins/openwhisk.md Outdated Show resolved Hide resolved
@bzp2010 bzp2010 requested a review from spacewander November 23, 2021 05:12
@bzp2010 bzp2010 requested a review from tzssangglass November 23, 2021 09:33
@bzp2010 bzp2010 force-pushed the feat-plugin-openwhisk branch from 728f4d8 to 1f98c5e Compare November 25, 2021 07:29
@bzp2010 bzp2010 requested a review from tokers November 25, 2021 08:20
@bzp2010
Copy link
Contributor Author

bzp2010 commented Nov 25, 2021

Hi, @spacewander @membphis @tzssangglass @tokers. The CI error has been fixed.

@membphis
Copy link
Member

we also need to update the REAME.md @bzp2010

@membphis membphis merged commit 4f02605 into apache:master Nov 25, 2021
@membphis
Copy link
Member

we also need to update the REAME.md @bzp2010

please create a new issue about this, do this later.

@membphis
Copy link
Member

we also need to update the REAME.md @bzp2010

please create a new issue about this, do this later.

@bzp2010 any news?

besich pushed a commit to besich/apisix that referenced this pull request Dec 1, 2021
@bzp2010
feat: Apache OpenWhisk plugin (apache#5518)
635a468
@moonming moonming mentioned this pull request Dec 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@membphis membphis membphis approved these changes

@spacewander spacewander spacewander approved these changes

@tzssangglass tzssangglass Awaiting requested review from tzssangglass

@tokers tokers Awaiting requested review from tokers

Assignees

@bzp2010 bzp2010

Labels
plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposal: support Apache OpenWhisk serverless framework plugin
5 participants
@bzp2010 @membphis @spacewander @tokers @tzssangglass