Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(proxy-rewrite): add method proxy #5292

Merged
merged 11 commits into from
Oct 25, 2021
Merged

feat(proxy-rewrite): add method proxy #5292

merged 11 commits into from
Oct 25, 2021

Conversation

qizhendong1
Copy link
Contributor

@qizhendong1 qizhendong1 commented Oct 20, 2021 •
edited
Loading

What this PR does / why we need it:

fix: #5173

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@qizhendong1 qizhendong1 marked this pull request as ready for review October 21, 2021 01:05
@qizhendong1 qizhendong1 requested a review from tokers October 21, 2021 02:13
@qizhendong1
Copy link
Contributor Author

help review @spacewander

spacewander
spacewander reviewed Oct 21, 2021
View reviewed changes
apisix/plugins/proxy-rewrite.lua Outdated Show resolved Hide resolved
apisix/plugins/proxy-rewrite.lua Outdated Show resolved Hide resolved
tokers
tokers reviewed Oct 21, 2021
View reviewed changes
docs/en/latest/plugins/proxy-rewrite.md Outdated Show resolved Hide resolved
apisix/plugins/proxy-rewrite.lua Outdated Show resolved Hide resolved
@tokers
Copy link
Contributor

tokers commented Oct 21, 2021

Should add some test cases to cover the changes @zhendongcmss .

@qizhendong1 qizhendong1 requested a review from tokers October 22, 2021 01:06
spacewander
spacewander reviewed Oct 22, 2021
View reviewed changes
docs/en/latest/plugins/proxy-rewrite.md Outdated Show resolved Hide resolved
t/plugin/proxy-rewrite.t Outdated Show resolved Hide resolved
spacewander
spacewander reviewed Oct 22, 2021
View reviewed changes
t/plugin/proxy-rewrite3.t Outdated Show resolved Hide resolved
docs/en/latest/plugins/proxy-rewrite.md Outdated Show resolved Hide resolved
t/plugin/proxy-rewrite3.t Outdated Show resolved Hide resolved
spacewander
spacewander reviewed Oct 22, 2021
View reviewed changes
t/lib/server.lua Outdated Show resolved Hide resolved
@qizhendong1 qizhendong1 requested a review from tokers October 24, 2021 10:20
spacewander
spacewander approved these changes Oct 25, 2021
View reviewed changes
t/plugin/proxy-rewrite3.t Outdated Show resolved Hide resolved
t/plugin/proxy-rewrite3.t Outdated Show resolved Hide resolved
@qizhendong1
Copy link
Contributor Author

qizhendong1 commented Oct 25, 2021 •
edited
Loading

@spacewander Are there commands used on comment box to restart CICD chekcs. The CICD checks often fail due to other test cases.

@spacewander
Copy link
Member

@spacewander Are there commands used on comment box to restart CICD chekcs. The CICD checks often fail due to other test cases.

I see.

@spacewander spacewander merged commit a348fff into apache:master Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tokers tokers tokers approved these changes

@spacewander spacewander spacewander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

request help: How can I transfer the request method from GET to POST when creating a new router ?
3 participants
@qizhendong1 @tokers @spacewander