Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stream): add limit-conn #4515

Merged
merged 9 commits into from
Jul 13, 2021
Merged

feat(stream): add limit-conn #4515

merged 9 commits into from
Jul 13, 2021

Conversation

spacewander
Copy link
Member

Signed-off-by: spacewander [email protected]

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Signed-off-by: spacewander <[email protected]>
@spacewander spacewander marked this pull request as ready for review July 1, 2021 12:19
https: //github.com/apache/pull/4515/checks?check_run_id=2962435093
Signed-off-by: spacewander <[email protected]>
Signed-off-by: spacewander <[email protected]>
Signed-off-by: spacewander <[email protected]>
@@ -35,6 +35,9 @@ title: limit-conn

**注:key 是可以被用户自定义的,只需要修改插件的一行代码即可完成。并没有在插件中放开是处于安全的考虑。**

: when used in the stream proxy, only `remote_addr` and `server_addr` can be used as `key`. And `rejected_code` is meaningless.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the meaning of the leading colon symbol?

a
Signed-off-by: spacewander <[email protected]>
b
Signed-off-by: spacewander <[email protected]>
@spacewander spacewander marked this pull request as draft July 2, 2021 05:26
@spacewander spacewander force-pushed the lcs branch 4 times, most recently from 31f8320 to 8d4a88a Compare July 2, 2021 08:48
t
Signed-off-by: spacewander <[email protected]>
@spacewander spacewander marked this pull request as ready for review July 2, 2021 09:41
@juzhiyuan juzhiyuan requested a review from tao12345666333 July 8, 2021 07:49
Signed-off-by: spacewander <[email protected]>
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.
Leave a comment, but it doesn’t affect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants