-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support var in upstream_uri on proxy-rewrite plugin #3139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added ability to use ctx.var in upstream_uri
Need to add semantic "PR" title, for example: |
We need test cases to cover this feature. |
Please merge master to make CI pass. |
spacewander
changed the title
ctx.var in upstream_uri on proxy-rewrite plugin
feat: support var in upstream_uri on proxy-rewrite plugin
Dec 28, 2020
You can write test like apisix/t/plugin/proxy-rewrite.t Lines 477 to 526 in 45e909a
|
membphis
requested changes
Dec 29, 2020
spacewander
reviewed
Jan 4, 2021
BFergerson
commented
Jan 4, 2021
spacewander
approved these changes
Jan 4, 2021
tokers
approved these changes
Jan 4, 2021
membphis
approved these changes
Jan 5, 2021
ping @membphis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds the ability to use
ctx.var
inupstream_uri
on the proxy-rewrite plugin.Fixes #3133