Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(proxy-cache): store the temporary file under cache directory. #2317

Merged
merged 6 commits into from
Oct 4, 2020
Merged

feat(proxy-cache): store the temporary file under cache directory. #2317

merged 6 commits into from
Oct 4, 2020

Conversation

spacewander
Copy link
Member

@spacewander spacewander commented Sep 25, 2020 •
edited by membphis
Loading

When the temporary file directory and cache directory are under
different disk, this option can avoid unexpected performance hurt.

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible?

@spacewander
feat(proxy-cache): store the temporary file under cache directory.
a487d76 
When the temporary file directory and cache directory are under
different disk, this option can avoid unexpected performance hurt.
@liuhengloveyou
Copy link
Contributor

@moonming @membphis merge?

@moonming
Copy link
Member

@moonming @membphis merge?

I am not get your point

@spacewander spacewander merged commit a6611d3 into apache:master Oct 4, 2020
@moonming moonming added this to the 2.0 milestone Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moonming moonming moonming approved these changes

@membphis membphis membphis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@spacewander @liuhengloveyou @moonming @membphis