-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change: add more prometheus metrics(etcd modify index) #1888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nic-chen
changed the title
change: add more prometheus metrics(hostname, etcd modify index)
change: add more prometheus metrics(etcd modify index)
Jul 23, 2020
moonming
reviewed
Jul 24, 2020
Because we added some new metrics this time, it will affect the performance, so let’s do a simple performance test. |
membphis
reviewed
Jul 26, 2020
@nic-chen if you have fixed them, you can click this button, it means you have fixed it. |
membphis
requested changes
Jul 29, 2020
membphis
requested changes
Jul 29, 2020
membphis
reviewed
Jul 30, 2020
membphis
approved these changes
Jul 30, 2020
@nic-chen please update the checklist, it seems that we are missing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
add more prometheus metrics for better understanding the situation of APISIX nodes.
#1885
Pre-submission checklist: