Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change: Batch_Processor -> batch_processor (name style) #1522

Closed
membphis opened this issue Apr 28, 2020 · 4 comments · Fixed by #1927
Closed

change: Batch_Processor -> batch_processor (name style) #1522

membphis opened this issue Apr 28, 2020 · 4 comments · Fixed by #1927
Assignees
@sshniro

Comments

@membphis
Copy link
Member

https://github.com/apache/incubator-apisix/blob/614f6a756387c6cbc3c3d3aa7959537091871d01/apisix/utils/batch-processor.lua#L106

and we need to fix the other similar points.
@membphis membphis changed the title change: Batch_Processor -> batch_processor change: Batch_Processor -> batch_processor (name style) Apr 28, 2020
@sshniro
Copy link
Member

sshniro commented Apr 29, 2020

Will update this after the merge of this PR:
#1525

@membphis
Copy link
Member Author

@sshniro any news?

@sshniro
Copy link
Member

sshniro commented Jun 21, 2020

Will fix this during this week, got the OS corrupted need to reconfigure.

@membphis
Copy link
Member Author

many thx @sshniro

@sshniro sshniro mentioned this issue Jul 29, 2020
Merged
membphis pushed a commit that referenced this issue Jul 29, 2020
@sshniro
plugin(batch): change processor name and error return type fix (#1927)
0ad813e 
Fix #1522
Fix #1521
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sshniro sshniro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

batch processor name and error return type fix sshniro/incubator-apisix
2 participants
@membphis @sshniro