Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

request help: is the worker_rlimit_core too small? #1101

Closed
spacewander opened this issue Feb 2, 2020 · 1 comment · Fixed by #1105
Closed

request help: is the worker_rlimit_core too small? #1101

spacewander opened this issue Feb 2, 2020 · 1 comment · Fixed by #1105

Comments

@spacewander
Copy link
Member

spacewander commented Feb 2, 2020 •
edited
Loading

https://github.com/apache/incubator-apisix/blob/master/bin/apisix#L98
Currently we configure the worker_rlimit_core to 500MiB, which may be big enough for normal situation, but might truncate the core file in some cases. The size of the core file is equal to the memory used by LuaJIT + Nginx + shared memory among workers, which could be larger than 500MiB.

IMHO, it'd be better to limit the core size to 4GiB under 32 bits platform, and 16GiB elsewhere.
@membphis
Copy link
Member

membphis commented Feb 3, 2020

PR welcome, good catch

spacewander added a commit to spacewander/incubator-apisix that referenced this issue Feb 4, 2020
@spacewander
feature: increase the default size of the core file
21f2290 
Close apache#1101.
@spacewander spacewander mentioned this issue Feb 4, 2020
Merged
membphis pushed a commit that referenced this issue Feb 4, 2020
@spacewander
feature: increase the default size of the core file (#1105)
abcd197 
Close #1101.
SaberMaster pushed a commit to SaberMaster/incubator-apisix that referenced this issue Jun 30, 2020
@spacewander @SaberMaster
feature: increase the default size of the core file (apache#1105)
f05b5da 
Close apache#1101.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feature: increase the default size of the core file spacewander/incubator-apisix
2 participants
@spacewander @membphis