Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: the test command under Linux is incorrect with perl 5.26 #1091

Closed
spacewander opened this issue Jan 24, 2020 · 1 comment
Closed

bug: the test command under Linux is incorrect with perl 5.26 #1091

spacewander opened this issue Jan 24, 2020 · 1 comment

Comments

@spacewander
Copy link
Member

Type make test under Linux got Can't locate t/APISIX.pm in @INC.

The code in Makefile:

test:
ifeq ($(UNAME),Darwin)
	prove -I../test-nginx/lib -I./ -r -s t/
else
	prove -I../test-nginx/lib -r -s t/
endif

It seems that the difference the behavior is caused by the version of perl instead of the platform. The perl I used is v5.26.1.

Maybe we can always add -I. in the command regardless of the platform or the version of perl? Adding extra path isn't harmful.

@spacewander spacewander changed the title bug: the test command under Linux is incorrect bug: the test command under Linux is incorrect with perl 5.26 Jan 24, 2020
@membphis
Copy link
Member

membphis commented Feb 1, 2020

welcome PR ^_^

spacewander added a commit to spacewander/incubator-apisix that referenced this issue Feb 1, 2020
SaberMaster pushed a commit to SaberMaster/incubator-apisix that referenced this issue Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants