-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix json unmarshal error when list plguins #888
Conversation
Codecov Report
@@ Coverage Diff @@
## master #888 +/- ##
==========================================
+ Coverage 32.01% 32.04% +0.02%
==========================================
Files 70 70
Lines 7749 7752 +3
==========================================
+ Hits 2481 2484 +3
Misses 4993 4993
Partials 275 275
Continue to review full report at Codecov.
|
Thanks! It's on my list |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cmssczy Thanks for your PR, could you give us an example about the response? Fair to say, I didn't realize the difference.
@tokers {
"serverless-pre-function": {
"version": 0.1,
"priority": 10000
},
"echo": {
"version": 0.1,
"priority": 412
}
} It is a json struct with unknown field names but not a string slice. So I think we should use a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We need a mechanism to ensure that the APISIX interface we are using is not outdated. |
yep. we may need to convert directly from the upstream schema. now let's move forward. |
Type of change:
What this PR does / why we need it:
bug fix #883
the response body is JSON with unknown field names but not a string slice.
Pre-submission checklist: