Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ingress LB status records #788

Merged
merged 1 commit into from
Dec 8, 2021

Conversation

tao12345666333
Copy link
Member

@tao12345666333 tao12345666333 commented Dec 7, 2021

Signed-off-by: Jintao Zhang [email protected]

Please answer these questions before submitting a pull request

  • Why submit this pull request?

  • Bugfix

  • New feature provided

  • Improve performance

  • Backport patches

  • Related issues


Bugfix

  • Description

When updating the status, it should carry its generation

  • How to fix?

New feature or improvement

  • Describe the details and related test reports.

Backport patches

  • Why need to backport?

  • Source branch

  • Related commits and pull requests

  • Target branch

@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2021

Codecov Report

Merging #788 (2032d88) into master (1bbadf0) will decrease coverage by 0.29%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #788      +/-   ##
==========================================
- Coverage   32.42%   32.12%   -0.30%     
==========================================
  Files          65       66       +1     
  Lines        6872     6876       +4     
==========================================
- Hits         2228     2209      -19     
- Misses       4396     4412      +16     
- Partials      248      255       +7     
Impacted Files Coverage Δ
pkg/ingress/status.go 0.00% <0.00%> (ø)
pkg/apisix/plugin.go 80.00% <0.00%> (-20.00%) ⬇️
pkg/apisix/cluster.go 30.02% <0.00%> (-3.31%) ⬇️
pkg/apisix/route.go 36.91% <0.00%> (-2.02%) ⬇️
test/e2e/e2e.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bbadf0...2032d88. Read the comment docs.

@tao12345666333 tao12345666333 marked this pull request as ready for review December 8, 2021 01:28
@tao12345666333 tao12345666333 merged commit fe4a824 into apache:master Dec 8, 2021
@tao12345666333 tao12345666333 deleted the fix-ingress-lb-status branch December 8, 2021 06:20
Sindweller pushed a commit to Sindweller/apisix-ingress-controller that referenced this pull request Dec 18, 2021
tao12345666333 added a commit to tao12345666333/ingress-controller that referenced this pull request Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants