Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: support to use kustomize install all resources #72

Merged
merged 4 commits into from
Dec 10, 2020
Merged

chore: support to use kustomize install all resources #72

merged 4 commits into from
Dec 10, 2020

Conversation

tokers
Copy link
Contributor

@tokers tokers commented Dec 9, 2020

Closing #54 .

@tokers tokers added this to the 0.1.0 milestone Dec 9, 2020
@tokers tokers requested a review from gxthrj December 9, 2020 07:54
@tokers tokers self-assigned this Dec 9, 2020
@membphis
Copy link
Member

membphis commented Dec 9, 2020

love this PR, need @gxthrj confirm

@moonming
Copy link
Member

moonming commented Dec 9, 2020

please remove Chinese doc

@tokers
Copy link
Contributor Author

tokers commented Dec 9, 2020

please remove Chinese doc

@gxthrj The deploy.md is written in Chinese, is this deliberate?

@tokers
Copy link
Contributor Author

tokers commented Dec 9, 2020

Contents in deploy.md is highly duplicated with others, maybe we can just remove it.

@gxthrj
Copy link
Contributor

gxthrj commented Dec 9, 2020 •
edited
Loading

Yes, we can remove it , and the content has been moved to usage.md and install.md.

@tokers
Copy link
Contributor Author

tokers commented Dec 9, 2020

please remove Chinese doc

Removed.

@membphis
Copy link
Member

membphis commented Dec 9, 2020

@tokers you delete file docs/deploy.md, I think we need to update some documents that link to this file.

gxthrj
gxthrj reviewed Dec 9, 2020
View reviewed changes
docs/develop.md Outdated
- au

EOF
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add shell

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@tokers
Copy link
Contributor Author

tokers commented Dec 9, 2020

@tokers you delete file docs/deploy.md, I think we need to update some documents that link to this file.

I have look through files in this project, it seems no file references to deploy.md.

@tokers
Copy link
Contributor Author

tokers commented Dec 9, 2020

Fixed.

membphis
membphis reviewed Dec 9, 2020
View reviewed changes
Copy link
Member

@membphis membphis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tokers tokers merged commit 14a399a into apache:master Dec 10, 2020
@tokers tokers deleted the chore/kustomize branch December 10, 2020 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@membphis membphis membphis left review comments

@gxthrj gxthrj gxthrj approved these changes

Assignees

@tokers tokers

Labels
None yet
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@tokers @membphis @moonming @gxthrj