Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid retrying caused by 404 when deleting cache #424

Merged
merged 3 commits into from
May 8, 2021

Conversation

gxthrj
Copy link
Contributor

@gxthrj gxthrj commented May 7, 2021

Please answer these questions before submitting a pull request

  • Why submit this pull request?
  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

@gxthrj gxthrj added this to the 0.6.0 milestone May 7, 2021
@gxthrj gxthrj changed the title fix: Avoid retrying caused by deleting cache 404 fix: Avoid retrying caused by 404 when deleting cache May 7, 2021
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tokers
Copy link
Contributor

tokers commented May 7, 2021

@gxthrj Should also handle stream route and global rule

@codecov-commenter
Copy link

codecov-commenter commented May 8, 2021

Codecov Report

Merging #424 (76c8a95) into master (9317acf) will increase coverage by 0.28%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #424      +/-   ##
==========================================
+ Coverage   36.79%   37.07%   +0.28%     
==========================================
  Files          44       44              
  Lines        3786     3795       +9     
==========================================
+ Hits         1393     1407      +14     
+ Misses       2214     2211       -3     
+ Partials      179      177       -2     
Impacted Files Coverage Δ
pkg/apisix/global_rule.go 32.59% <0.00%> (-0.25%) ⬇️
pkg/apisix/route.go 35.29% <0.00%> (+1.96%) ⬆️
pkg/apisix/ssl.go 35.03% <0.00%> (-0.26%) ⬇️
pkg/apisix/stream_route.go 32.08% <0.00%> (-0.25%) ⬇️
pkg/apisix/upstream.go 33.08% <0.00%> (-0.26%) ⬇️
pkg/ingress/manifest.go 63.21% <0.00%> (-4.69%) ⬇️
pkg/kube/translation/apisix_route.go 42.71% <0.00%> (-0.56%) ⬇️
pkg/apisix/cluster.go 32.90% <0.00%> (+5.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9317acf...76c8a95. Read the comment docs.

@tokers tokers merged commit 76bfd45 into apache:master May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants