Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add ack deployment #183

Merged
merged 5 commits into from
Jan 20, 2021
Merged

docs: add ack deployment #183

merged 5 commits into from
Jan 20, 2021

Conversation

gxthrj
Copy link
Contributor

@gxthrj gxthrj commented Jan 19, 2021

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #183 (e5b62ad) into master (0be8659) will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #183      +/-   ##
==========================================
+ Coverage   48.65%   48.78%   +0.13%     
==========================================
  Files          30       30              
  Lines        1482     1482              
==========================================
+ Hits          721      723       +2     
+ Misses        675      673       -2     
  Partials       86       86              
Impacted Files Coverage Δ
pkg/seven/state/solver.go 3.38% <0.00%> (+1.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0be8659...e5b62ad. Read the comment docs.

@gxthrj
Copy link
Contributor Author

gxthrj commented Jan 20, 2021

cc @tokers @membphis @moonming

docs/deployments/ack.md Outdated Show resolved Hide resolved
Copy link
Member

@membphis membphis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do users find this article?

We should reference it in REAME.md.

@tokers
Copy link
Contributor

tokers commented Jan 20, 2021

How do users find this article?

We should reference it in REAME.md.

All docs about deployment are linked by the How to Install section.

@gxthrj The link for ack is missing from install.md.

@membphis
Copy link
Member

image

@gxthrj gxthrj merged commit 5fa2340 into apache:master Jan 20, 2021
@gxthrj gxthrj deleted the kv/ack branch January 20, 2021 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants