Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: abstract ingress/controller.Controller #155

Merged
merged 1 commit into from
Jan 7, 2021

Conversation

tokers
Copy link
Contributor

@tokers tokers commented Jan 5, 2021

No description provided.

@gxthrj
Copy link
Contributor

gxthrj commented Jan 6, 2021

Approved, and then I will test the ResyncInterval base this PR.

@codecov-io
Copy link

Codecov Report

Merging #155 (b4eeccb) into master (2a8e8a7) will decrease coverage by 1.32%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #155      +/-   ##
==========================================
- Coverage   34.55%   33.22%   -1.33%     
==========================================
  Files          28       28              
  Lines        1314     1285      -29     
==========================================
- Hits          454      427      -27     
+ Misses        830      829       -1     
+ Partials       30       29       -1     
Impacted Files Coverage Δ
cmd/ingress/ingress.go 72.13% <25.00%> (-6.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a8e8a7...b4eeccb. Read the comment docs.

@tokers tokers merged commit edbb02a into apache:master Jan 7, 2021
@tokers tokers deleted the chore/ingress-controller branch January 7, 2021 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants