feat: set serverUrlMap with env, update cypress, update stylelint #2583
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2583 +/- ##
===========================================
- Coverage 76.08% 60.20% -15.89%
===========================================
Files 136 134 -2
Lines 3601 3553 -48
Branches 868 867 -1
===========================================
- Hits 2740 2139 -601
- Misses 861 1414 +553
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
web/config/defaultSettings.ts
Outdated
| }; | ||
|
|
||
| if (REACT_APP_ENV === 'test' && !test) { | ||
| throwPromptError`SERVER_URL_TEST`; |
There was a problem hiding this comment.
LGTM, but should we use the most generic function call syntax? like throwPromptError("SERVER_URL_TEST");, although it still works, it may be confusing for those unfamiliar with it.
There was a problem hiding this comment.
Although we don't seem to have used it much in this project yet, it is actually relatively common, for example in emotion, styled components, graphql...
|
BTW, the frontend e2e CI was crashed, if you have no other changes, please let me rewrite it to run it. @ |
SkyeYoung
changed the title
* upstream/master: (23 commits) feat: Add config struct of OpenID-Connect Login (apache#2597) feat: set serverUrlMap with env, update cypress, update stylelint (apache#2583) chore: fix function name typo (apache#2599) fix: page refresh causes deletion exception (apache#2593) feat: support show all enable plugin list tab (apache#2585) fix: drawer components delete plugin not working (apache#2573) feat: add batch delete function for route (apache#2502) test: reduce fe ci time (apache#2557) doc(csp): add correct csp rule (apache#2548) doc: add a notice about the compatibility of Ingress and Dashboard (apache#2552) fix: add judgement for last_report_time (apache#2551) fix: cli test invalid etcd (apache#2544) feat: fix actions version to root version (apache#2521) fix: duplicate ID (apache#2501) fix: block arbitrary file index (apache#2497) docs: update deploy-with-docker.md (apache#2472) feat: translating Turkish for new features (apache#2487) docs: add new import and export docs to sidebar (apache#2485) docs: add data loader and new OpenAPI 3 loader (apache#2484) feat: support data loader in frontend (apache#2480) ... # Conflicts: # api/internal/route.go # web/config/defaultSettings.ts # web/yarn.lock
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
Related issues
fix/resolve #
Checklist: