Feat: add tip and preset model for plugin editor, improve e2e stability #2581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Young <[email protected]>
Co-authored-by: Young <[email protected]>
|
All test cases of Dashboard have been repaired and passed, and the issue#2615 can be closed.
cc @butterfly1924 plugin-schema.cy.js has been fixed. |
FangSen9000
commented
Sep 30, 2022
|
|
||
| if (cases.length === i + 1) { | ||
| cy.reload(true); | ||
| } |
There was a problem hiding this comment.
Frequent refreshing is the root cause of plugin-schema.cy.js' error. In fact, the logic of the test case is completely correct. which is the problem of umi.js itself
LiteSun
approved these changes
Sep 30, 2022
|
I got rid of the prompts, maybe to make it a little more minimal @SkyeYoung |
Baoyuantop
approved these changes
Sep 30, 2022
guoqqqi
approved these changes
Sep 30, 2022
hongbinhsu
added a commit
to fitphp/apix-dashboard
that referenced
this pull request
Nov 7, 2022
* upstream/master: fix: change default CSP value (apache#2601) fix: ant-table unable to request (apache#2641) fix: plugin_config missing on service exist (apache#2657) feat: add etcd store auto re-initialize (apache#2650) feat: add login filter of OpenID-Connect (apache#2608) feat:Configure plug-ins to support this feature (apache#2647) feat: Adding a Loading state to buttons (apache#2630) feat: dashboard support windows (apache#2619) Feat: add tip and preset model for plugin editor, improve e2e stability (apache#2581) docs: add Slack invitation link badge (apache#2617) # Conflicts: # .github/workflows/backend-cli-test.yml # Dockerfile # api/test/shell/cli_test.sh # web/src/components/Footer/index.tsx # web/src/components/RightContent/index.tsx # web/src/pages/ServerInfo/List.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
Reason:
We need to tell users clearly that which part of the data should be filled.
Modification:
effect:
Potential effects:
After the change:
modelpreview2.webm
Note that the latest one has removed the prompt box and is slightly different from the video
Related issues
#1363 #2615
Checklist: