Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Users can create a Consumer in Dashboard without enabling the plugin #2442

Merged
merged 9 commits into from
Jun 6, 2022

Conversation

kukiiu
Copy link
Contributor

@kukiiu kukiiu commented Apr 25, 2022

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix

What changes will this PR take into?

Users can create a Consumer in Dashboard without enabling the plugin.
Fix some missing key bug.

Related issues

fix/resolve #2441

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@kukiiu kukiiu changed the title Users can create a Consumer in Dashboard without enabling the plugin fix: Users can create a Consumer in Dashboard without enabling the plugin Apr 25, 2022
@Baoyuantop
Copy link
Contributor

Hi @kukiiu, thanks for your contribution. There are a few issues to deal with here:

  1. Need for conflict resolution
  2. The PR contains additional file changes that may require merging the master branch
  3. You can delete the unneeded code directly

kukiiu added a commit to kukiiu/apisix-dashboard that referenced this pull request Apr 26, 2022
@Baoyuantop Baoyuantop requested a review from guoqqqi April 27, 2022 03:13
Copy link
Member

@guoqqqi guoqqqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code LGTM, thanks your contribution 😄

@Baoyuantop Baoyuantop merged commit a2fe71d into apache:master Jun 6, 2022
hongbinhsu pushed a commit to fitphp/apix-dashboard that referenced this pull request Jun 16, 2022
* upstream/master:
  test: remove stale E2E cases (apache#2475)
  feat: basic support Apache APISIX 2.14.1 (apache#2464)
  fix: Users can create a Consumer in Dashboard without enabling the plugin (apache#2442)
  fix: change "Route List" to "Routes" (apache#2453)
  fix: advance matching in the route create page causes the page to crash (apache#2440)
  feat: release 2.13 (apache#2458)
  feat: support Turkish Language (apache#2452)

# Conflicts:
#	web/package.json
@kukiiu kukiiu deleted the feat_2441 branch June 25, 2022 13:58
bzp2010 pushed a commit to bzp2010/apisix-dashboard that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard allows the creation of a Consumer without enabling the plugin
5 participants