Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support post args advanced match #2231

Merged
merged 3 commits into from
Dec 2, 2021

Conversation

bzp2010
Copy link
Contributor

@bzp2010 bzp2010 commented Dec 1, 2021

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

Support for advanced POST form-based route matching settings introduced in APISIX 2.11. At same time, I also add some tips for advance match.

image

Related issues

apache/apisix#5409

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@bzp2010 bzp2010 added enhancement New feature or request frontend labels Dec 1, 2021
@bzp2010 bzp2010 self-assigned this Dec 1, 2021
@juzhiyuan
Copy link
Member

LGTM from changes :)

@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2021

Codecov Report

Attention: Patch coverage is 36.36364% with 7 lines in your changes missing coverage. Please review.

Project coverage is 67.96%. Comparing base (cc1e5d4) to head (c480fa5).
Report is 165 commits behind head on master.

Files with missing lines Patch % Lines
web/src/pages/Route/transform.ts 33.33% 4 Missing ⚠️
...pages/Route/components/Step1/MatchingRulesView.tsx 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2231      +/-   ##
==========================================
- Coverage   68.07%   67.96%   -0.12%     
==========================================
  Files         127      127              
  Lines        3352     3359       +7     
  Branches      824      826       +2     
==========================================
+ Hits         2282     2283       +1     
- Misses       1070     1076       +6     
Flag Coverage Δ
frontend-e2e-test 67.96% <36.36%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liuxiran liuxiran merged commit cbcac5f into apache:master Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants