Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove version match on web #2023

Merged
merged 1 commit into from
Aug 2, 2021

Conversation

Baoyuantop
Copy link
Contributor

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

Remove version match result alert in web

Related issues

resolve #2005

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@netlify
Copy link

netlify bot commented Aug 1, 2021

✔️ Deploy Preview for apisix-dashboard ready!

🔨 Explore the source changes: 5e1f91f

🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix-dashboard/deploys/61062723c8aca20007de40e2

😎 Browse the preview: https://deploy-preview-2023--apisix-dashboard.netlify.app/

@codecov-commenter
Copy link

Codecov Report

Merging #2023 (5e1f91f) into master (33c735e) will decrease coverage by 3.89%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2023      +/-   ##
==========================================
- Coverage   67.92%   64.03%   -3.90%     
==========================================
  Files         182      121      -61     
  Lines        6972     3156    -3816     
  Branches      753      753              
==========================================
- Hits         4736     2021    -2715     
+ Misses       1949     1135     -814     
+ Partials      287        0     -287     
Flag Coverage Δ
backend-e2e-test ?
backend-e2e-test-ginkgo ?
backend-unit-test ?
frontend-e2e-test 64.03% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/components/RightContent/index.tsx 83.33% <ø> (-3.34%) ⬇️
web/src/components/Plugin/PluginDetail.tsx 65.82% <100.00%> (+0.21%) ⬆️
web/src/components/Plugin/UI/limit-req.tsx 100.00% <100.00%> (ø)
web/src/components/Plugin/UI/plugin.tsx 82.60% <100.00%> (ø)
web/src/components/Upstream/components/Type.tsx 100.00% <100.00%> (ø)
api/internal/log/zap.go
api/internal/handler/schema/plugin.go
api/internal/core/migrate/dataset.go
api/internal/utils/version.go
api/internal/core/server/server.go
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 446377d...5e1f91f. Read the comment docs.

@juzhiyuan
Copy link
Member

cc @nic-chen to remove Backend's logics.

@starsz starsz requested review from LiteSun and liuxiran August 1, 2021 15:25
@liuxiran liuxiran merged commit fe6e155 into apache:master Aug 2, 2021
@Baoyuantop Baoyuantop deleted the remove-version-match-web branch August 2, 2021 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove version match logics from both Web and Backend
5 participants