-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: server manager #1956
refactor: server manager #1956
Conversation
✔️ Deploy Preview for apisix-dashboard ready! 🔨 Explore the source changes: eeb8bbc 🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix-dashboard/deploys/60d975c1ff28bc0007fd8b5a 😎 Browse the preview: https://deploy-preview-1956--apisix-dashboard.netlify.app |
Codecov Report
@@ Coverage Diff @@
## master #1956 +/- ##
==========================================
- Coverage 66.89% 63.54% -3.35%
==========================================
Files 179 60 -119
Lines 6551 3421 -3130
Branches 753 0 -753
==========================================
- Hits 4382 2174 -2208
+ Misses 1899 967 -932
- Partials 270 280 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
e08ad67
to
b55762b
Compare
dbe9819
to
367d174
Compare
557e532
to
29c7210
Compare
Hi, @tokers |
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
Refactoring the management code of Manager API to help to initialize, start and stop. Reduce redundant code and improve readability.
I created a new
server
module ininternal/core
.It will help run according to the process of
NewServer()
->server.init()
->Start()
->Stop()
.It covers the functions of initializing etcd client, initializing store, initializing route and starting HTTP server.
Checklist: