Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: route page Protable #1887

Merged
merged 1 commit into from
May 12, 2021
Merged

fix: route page Protable #1887

merged 1 commit into from
May 12, 2021

Conversation

iamayushdas
Copy link
Contributor

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?
Now the Route page will support all view ports and won't get messed up due to different viewports

Related issues

fix/resolve #1815

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@netlify
Copy link

netlify bot commented May 11, 2021

Deploy preview for apisix-dashboard ready!

Built with commit 762f70f

https://deploy-preview-1887--apisix-dashboard.netlify.app

@iamayushdas
Copy link
Contributor Author

cc @juzhiyuan @liuxiran @guoqqqi

@iamayushdas
Copy link
Contributor Author

should i also do this to other pages? @liuxiran
IMO: its not required

Copy link
Member

@juzhiyuan juzhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to see this change

@liuxiran
Copy link
Contributor

should i also do this to other pages? @liuxiran
IMO: its not required

agree with you, it is not required for other page ^^

Copy link
Contributor

@liuxiran liuxiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, LGTM

@LiteSun LiteSun merged commit fa9c292 into apache:master May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fe]: issue regarding viewport in route page
4 participants