Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unstable ci in create_and_edit_upstream_with_no_nodes.spec.js #1826

Merged
merged 1 commit into from
Apr 27, 2021

Conversation

liuxiran
Copy link
Contributor

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

Please update this section with detailed description.

@liuxiran FE ci failed after this pr got merged. Could you please take a look, please refer to https://github.com/apache/apisix-dashboard/runs/2430236911. Thanks.

come from: #1812 (comment)

this pr tried to solve this unstable test case.

Related issues

None

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@netlify
Copy link

netlify bot commented Apr 26, 2021

Deploy preview for apisix-dashboard ready!

Built with commit 907adfb

https://deploy-preview-1826--apisix-dashboard.netlify.app

@codecov-commenter
Copy link

Codecov Report

Merging #1826 (907adfb) into master (2f3717f) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1826      +/-   ##
==========================================
+ Coverage   72.07%   72.14%   +0.06%     
==========================================
  Files         125      125              
  Lines        2944     2944              
  Branches      711      711              
==========================================
+ Hits         2122     2124       +2     
+ Misses        822      820       -2     
Flag Coverage Δ
frontend-e2e-test 72.14% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/helpers.tsx 72.13% <0.00%> (+3.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f3717f...907adfb. Read the comment docs.

Copy link
Member

@imjoey imjoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thank you @liuxiran.

@imjoey imjoey merged commit 5d6d7fc into apache:master Apr 27, 2021
@imjoey imjoey mentioned this pull request Apr 27, 2021
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants