feat: added types for Plugins #1736

juzhiyuan · 2021-04-10T10:07:13Z

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

Bugfix
New feature provided
Improve performance
Backport patches

What changes will this PR take into?

added Type for Plugin List according to https://apisix.apache.org/docs/apisix/plugins/batch-requests
added i18n for Type
for custom plugins, all belong to other by default, or belong to Custom?

Checklist:

Did you explain what problem does this PR solve? Or what new features have been added?
Have you added corresponding test cases?
Have you modified the corresponding document?
Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

juzhiyuan · 2021-04-10T10:08:16Z

type order: https://github.com/apache/apisix-dashboard/pull/1736/files#diff-7955d0817a8badfa4c7afe9cb21a06bc0fc5680f563ced07271b969cc2619ff3R36-R46

i18n: https://github.com/apache/apisix-dashboard/pull/1736/files#diff-267cf2f145e175cf8df0a7fa78778bd44b28469b5d482a1e7b6a3dbaad424230R24-R32

juzhiyuan · 2021-04-10T10:11:14Z

@moonming Do the translations make sense? the text is a little short from screenshot

moonming · 2021-04-10T10:18:15Z

Why are there server info and echo plugins? And it should display all the plug-ins on one page, not just click on the category to display

moonming · 2021-04-10T10:19:10Z

And the icons are ...

juzhiyuan · 2021-04-10T10:48:18Z

Will handle the icons, do there have other questions about Plug-in Type? It's according to docs category. 🤔 I think the name should get updated IMO.

moonming · 2021-04-10T10:54:29Z

I'm sure I sent you a list of plugins, not the current one 琚致远 ***@***.***>于2021年4月10日周六下午6:48写道：

Will handle the icons, do there have other questions about Plug-in Type? It's according to docs category. 🤔 I think the name should get updated IMO. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1736 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGJZBK7GLZZKGI6TX2EKV43TIAUH3ANCNFSM42WLDBKA> .

-- Thanks, Ming Wen Twitter: _WenMing

netlify · 2021-04-12T14:55:17Z

Deploy preview for apisix-dashboard ready!

Built with commit 6828ec7

https://deploy-preview-1736--apisix-dashboard.netlify.app

web/src/components/Plugin/data.tsx

web/src/components/Plugin/locales/zh-CN.ts

juzhiyuan · 2021-04-12T15:04:10Z

This PR will support disable & enable status on the Plugin Market: #1610

juzhiyuan · 2021-04-12T15:11:11Z

I just created an issue to track Icon for Plugins: #1760

web/src/components/Plugin/PluginPage.tsx

membphis · 2021-04-14T23:33:47Z

ci failed

web/src/components/Plugin/data.tsx

membphis · 2021-04-14T23:38:11Z

web/src/components/Plugin/data.tsx

+    type: PluginType.serverless
+  },
+  "dubbo-proxy": {
+    type: PluginType.other


hide this too, it needs special openresty

https://apisix.apache.org/docs/apisix/plugins/dubbo-proxy/

I just rechecked docs, it seems that this Plugin could be configured from UI (Raw Editor I mean), do we really need to hide it?

cc @membphis @moonming

codecov-io · 2021-04-15T04:21:40Z

Codecov Report

Merging #1736 (db1247a) into master (10cadaa) will increase coverage by 0.19%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1736      +/-   ##
==========================================
+ Coverage   72.92%   73.11%   +0.19%     
==========================================
  Files         119      119              
  Lines        2825     2831       +6     
  Branches      678      681       +3     
==========================================
+ Hits         2060     2070      +10     
+ Misses        765      761       -4

Flag	Coverage Δ
frontend-e2e-test	`73.11% <100.00%> (+0.19%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
web/src/components/Plugin/PluginPage.tsx	`98.66% <100.00%> (-0.02%)`	⬇️
web/src/components/Plugin/data.tsx	`100.00% <100.00%> (ø)`
web/src/components/Plugin/service.ts	`95.23% <100.00%> (+1.90%)`	⬆️
web/src/components/Plugin/PluginDetail.tsx	`64.33% <0.00%> (-0.70%)`	⬇️
web/src/helpers.tsx	`72.13% <0.00%> (+3.27%)`	⬆️
web/src/components/Plugin/UI/plugin.tsx	`91.30% <0.00%> (+8.69%)`	⬆️
web/src/components/Plugin/UI/basic-auth.tsx	`100.00% <0.00%> (+33.33%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10cadaa...db1247a. Read the comment docs.

web/src/components/Plugin/data.tsx

…ute-type

juzhiyuan · 2021-04-15T05:21:33Z

As for this issue (plugins in one page), I created an issue here: #1776

Icon: #1760

Not urgent, but both are needed.

web/src/components/Plugin/locales/zh-CN.ts

juzhiyuan · 2021-04-15T06:25:05Z

web/src/components/Plugin/data.tsx

+  authentication = "authentication",
+  security = "security",
+  traffic = "traffic",
+  serverless = "serverless",


web/src/components/Plugin/data.tsx

web/src/components/Plugin/locales/en-US.ts

web/src/components/Plugin/locales/zh-CN.ts

juzhiyuan · 2021-04-15T08:24:22Z

web/src/components/Plugin/locales/en-US.ts

+  'component.plugin.traffic': 'Traffic Control',
+  'component.plugin.serverless': 'Serverless',
+  'component.plugin.observability': 'Tracing & Metrics & Logging',
+  'component.plugin.logging': 'Logging',


Do we still need logging? or assign them to observability too?

vote for observability

chore: added types for Plugin

f5e26e6

This comment has been minimized.

Sign in to view

juzhiyuan requested review from LiteSun, liuxiran, bzp2010, membphis and moonming April 10, 2021 10:09

juzhiyuan added 2 commits April 12, 2021 22:51

chore: update Plugin type

1d9c2e8

chore: update Plugin type

4a81b50

Merge branch 'master' into feat-route-type

d0f6710

juzhiyuan commented Apr 12, 2021

View reviewed changes

web/src/components/Plugin/data.tsx Outdated Show resolved Hide resolved

juzhiyuan commented Apr 12, 2021

View reviewed changes

web/src/components/Plugin/locales/zh-CN.ts Outdated Show resolved Hide resolved

chore: remove unused i18n

a949de4

LiteSun reviewed Apr 14, 2021

View reviewed changes

web/src/components/Plugin/PluginPage.tsx Outdated Show resolved Hide resolved

juzhiyuan added 2 commits April 14, 2021 19:24

Update PluginPage.tsx

d06f8da

Update data.tsx

db87f69

membphis reviewed Apr 14, 2021

View reviewed changes

juzhiyuan and others added 3 commits April 15, 2021 08:10

chore: update types

992ea4e

fix: ci

5f06909

Merge branch 'master' into feat-route-type

db1247a

membphis reviewed Apr 15, 2021

View reviewed changes

web/src/components/Plugin/data.tsx Outdated Show resolved Hide resolved

web/src/components/Plugin/data.tsx Outdated Show resolved Hide resolved

web/src/components/Plugin/data.tsx Outdated Show resolved Hide resolved

juzhiyuan added 4 commits April 15, 2021 13:04

feat: update types

f2409b1

Merge branch 'master' into feat-route-type

5e873b3

Merge remote-tracking branch 'juzhiyuan/feat-route-type' into feat-ro…

a9bfd18

…ute-type

fix: CI

cecb6cf

juzhiyuan requested a review from membphis April 15, 2021 05:17

juzhiyuan commented Apr 15, 2021

View reviewed changes

web/src/components/Plugin/locales/zh-CN.ts Outdated Show resolved Hide resolved

juzhiyuan changed the title ~~chore: added types for Plugin~~ feat: added types for Plugin Apr 15, 2021

juzhiyuan changed the title ~~feat: added types for Plugin~~ feat: added types for Plugins Apr 15, 2021

feat: remove useless category

f183333

juzhiyuan requested review from LiteSun and nic-chen April 15, 2021 06:16

feat: remove useless i18n

77f468e

juzhiyuan commented Apr 15, 2021

View reviewed changes

moonming approved these changes Apr 15, 2021

View reviewed changes

moonming requested changes Apr 15, 2021

View reviewed changes

web/src/components/Plugin/data.tsx Outdated Show resolved Hide resolved

moonming requested changes Apr 15, 2021

View reviewed changes

web/src/components/Plugin/locales/en-US.ts Outdated Show resolved Hide resolved

web/src/components/Plugin/locales/zh-CN.ts Outdated Show resolved Hide resolved

feat: use observability instead monitoring

6828ec7

juzhiyuan commented Apr 15, 2021

View reviewed changes

membphis approved these changes Apr 15, 2021

View reviewed changes

moonming approved these changes Apr 15, 2021

View reviewed changes

bzp2010 approved these changes Apr 15, 2021

View reviewed changes

juzhiyuan merged commit f1b8f0c into apache:master Apr 15, 2021

juzhiyuan deleted the feat-route-type branch April 15, 2021 09:29

juzhiyuan mentioned this pull request Apr 15, 2021

resolve PR comments #1775

Closed

3 tasks

Baoyuantop mentioned this pull request Apr 23, 2023

已经放开dubbo-proxy插件，但是界面上搜索不到此插件，有用过dubbo-proxy的没 #2792

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: added types for Plugins #1736

feat: added types for Plugins #1736

juzhiyuan commented Apr 10, 2021 •

edited

Loading

juzhiyuan commented Apr 10, 2021

This comment has been minimized.

juzhiyuan commented Apr 10, 2021

moonming commented Apr 10, 2021

moonming commented Apr 10, 2021

juzhiyuan commented Apr 10, 2021

moonming commented Apr 10, 2021 via email

netlify bot commented Apr 12, 2021 •

edited

Loading

juzhiyuan commented Apr 12, 2021

juzhiyuan commented Apr 12, 2021

membphis commented Apr 14, 2021

membphis Apr 14, 2021

juzhiyuan Apr 15, 2021 •

edited

Loading

codecov-io commented Apr 15, 2021

juzhiyuan commented Apr 15, 2021 •

edited

Loading

juzhiyuan Apr 15, 2021

juzhiyuan Apr 15, 2021

moonming Apr 15, 2021

feat: added types for Plugins #1736

feat: added types for Plugins #1736

Conversation

juzhiyuan commented Apr 10, 2021 • edited Loading

juzhiyuan commented Apr 10, 2021

This comment has been minimized.

juzhiyuan commented Apr 10, 2021

moonming commented Apr 10, 2021

moonming commented Apr 10, 2021

juzhiyuan commented Apr 10, 2021

moonming commented Apr 10, 2021 via email

netlify bot commented Apr 12, 2021 • edited Loading

juzhiyuan commented Apr 12, 2021

juzhiyuan commented Apr 12, 2021

membphis commented Apr 14, 2021

membphis Apr 14, 2021

Choose a reason for hiding this comment

juzhiyuan Apr 15, 2021 • edited Loading

Choose a reason for hiding this comment

codecov-io commented Apr 15, 2021

Codecov Report

juzhiyuan commented Apr 15, 2021 • edited Loading

juzhiyuan Apr 15, 2021

Choose a reason for hiding this comment

juzhiyuan Apr 15, 2021

Choose a reason for hiding this comment

moonming Apr 15, 2021

Choose a reason for hiding this comment

juzhiyuan commented Apr 10, 2021 •

edited

Loading

netlify bot commented Apr 12, 2021 •

edited

Loading

juzhiyuan Apr 15, 2021 •

edited

Loading

juzhiyuan commented Apr 15, 2021 •

edited

Loading