Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use Enable instead of Create on the Plugin List #1731

Merged
merged 6 commits into from
Apr 12, 2021

Conversation

juzhiyuan
Copy link
Member

@juzhiyuan juzhiyuan commented Apr 9, 2021

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

  • use Enable instead of Create on the Plugin list

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

image

image

@LiteSun
Copy link
Member

LiteSun commented Apr 11, 2021

Please sync master branch code to fix FE CI.

@codecov-io
Copy link

codecov-io commented Apr 11, 2021

Codecov Report

Merging #1731 (28148bf) into master (8b6080d) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1731      +/-   ##
==========================================
- Coverage   71.86%   71.80%   -0.07%     
==========================================
  Files          47       47              
  Lines        3128     3128              
==========================================
- Hits         2248     2246       -2     
- Misses        638      639       +1     
- Partials      242      243       +1     
Flag Coverage Δ
backend-e2e-test 62.65% <ø> (-0.07%) ⬇️
backend-e2e-test-ginkgo 49.64% <ø> (+0.54%) ⬆️
backend-unit-test 52.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/internal/core/store/store.go 87.95% <0.00%> (-1.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b6080d...28148bf. Read the comment docs.

@juzhiyuan juzhiyuan requested a review from membphis April 12, 2021 13:51
@membphis membphis merged commit b42904d into apache:master Apr 12, 2021
@juzhiyuan juzhiyuan deleted the juzhiyuan/plugin-rule branch April 12, 2021 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants