Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: enhanced test stability #1645

Merged
merged 3 commits into from
Mar 23, 2021
Merged

test: enhanced test stability #1645

merged 3 commits into from
Mar 23, 2021

Conversation

guoqqqi
Copy link
Member

@guoqqqi guoqqqi commented Mar 22, 2021

Please answer these questions before submitting a pull request


fixed CI error:
Update front-end E2E tests to enhance stability based on CI errors.

@codecov-io
Copy link

codecov-io commented Mar 22, 2021

Codecov Report

Merging #1645 (13970e8) into master (85efb37) will decrease coverage by 4.93%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1645      +/-   ##
==========================================
- Coverage   72.38%   67.45%   -4.94%     
==========================================
  Files         134       47      -87     
  Lines        5737     3116    -2621     
  Branches      665        0     -665     
==========================================
- Hits         4153     2102    -2051     
+ Misses       1341      767     -574     
- Partials      243      247       +4     
Flag Coverage Δ
backend-e2e-test ?
backend-e2e-test-ginkgo 48.04% <ø> (+0.32%) ⬆️
backend-unit-test 51.81% <ø> (ø)
frontend-e2e-test ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/internal/handler/data_loader/route_import.go 35.08% <0.00%> (-29.84%) ⬇️
api/internal/core/entity/entity.go 75.00% <0.00%> (-25.00%) ⬇️
api/internal/handler/global_rule/global_rule.go 66.12% <0.00%> (-17.75%) ⬇️
api/internal/utils/utils.go 54.11% <0.00%> (-11.77%) ⬇️
api/internal/route.go 76.47% <0.00%> (-8.83%) ⬇️
api/internal/core/store/storehub.go 67.28% <0.00%> (-3.74%) ⬇️
api/internal/filter/schema.go 52.10% <0.00%> (-3.37%) ⬇️
api/internal/core/store/validate.go 67.03% <0.00%> (-2.24%) ⬇️
api/internal/handler/label/label.go 80.18% <0.00%> (-1.89%) ⬇️
api/internal/core/store/store.go 87.95% <0.00%> (-1.21%) ⬇️
... and 88 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85efb37...13970e8. Read the comment docs.

Copy link
Contributor

@liuxiran liuxiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juzhiyuan juzhiyuan requested a review from LiteSun March 23, 2021 02:02
@guoqqqi guoqqqi requested a review from LiteSun March 23, 2021 05:53
@LiteSun LiteSun merged commit 9c27b57 into apache:master Mar 23, 2021
@guoqqqi guoqqqi deleted the fix-e2e-error branch March 23, 2021 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants