-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: (route_online_debug)Change the appended Content-type data to overlay to ensure that the Content-type is unique #1619
fix: (route_online_debug)Change the appended Content-type data to overlay to ensure that the Content-type is unique #1619
Conversation
7faebd7
to
2ac671f
Compare
related fe pr: #1612 |
Codecov Report
@@ Coverage Diff @@
## master #1619 +/- ##
==========================================
- Coverage 71.77% 61.93% -9.85%
==========================================
Files 133 47 -86
Lines 5471 3118 -2353
Branches 592 0 -592
==========================================
- Hits 3927 1931 -1996
+ Misses 1301 874 -427
- Partials 243 313 +70
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…the content type is unique
6875168
to
d84ab27
Compare
cc @liuxiran @LiteSun @juzhiyuan FE CI Failed PTAL. Thks. |
mark fe e2e errors:
fixed by two test commits |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fe local test passed, LGTM
…rlay to ensure that the Content-type is unique (apache#1619) Co-authored-by: liuxiran <[email protected]>
Please answer these questions before submitting a pull request
Why submit this pull request?
Bugfix
New feature provided
Improve performance
Backport patches
Related issues
Bugfix
Description
There is a bug in the use process. The user writes the
Content-type
to theheader-params
to forward the content type of the URL. The old logic uses thereq.Header.Add
method to generate multipleContent-type
values, which leads to the failure of the forwarding request.How to fix?
use
req.Header.Set
To override the ·Content-type· and ensure that the value is unique。