Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rewrite e2e test(rewrite-e2e-test-route-with-priority-test) with ginkgo #1582

Conversation

Jaycean
Copy link
Member

@Jaycean Jaycean commented Mar 12, 2021

Please answer these questions before submitting a pull request


New feature or improvement

  • Rewrite e2e test(rewrite-e2e-test-route-with-priority-test) with ginkgo

@membphis membphis requested a review from nic-chen March 14, 2021 15:40
@codecov-io
Copy link

codecov-io commented Mar 15, 2021

Codecov Report

Merging #1582 (df804ce) into master (9cb4b43) will decrease coverage by 5.29%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1582      +/-   ##
==========================================
- Coverage   71.64%   66.34%   -5.30%     
==========================================
  Files         132       46      -86     
  Lines        5339     3019    -2320     
  Branches      584        0     -584     
==========================================
- Hits         3825     2003    -1822     
+ Misses       1269      768     -501     
- Partials      245      248       +3     
Flag Coverage Δ
backend-e2e-test ?
backend-e2e-test-ginkgo 46.27% <ø> (-0.14%) ⬇️
backend-unit-test 51.54% <ø> (ø)
frontend-e2e-test ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/internal/handler/data_loader/route_import.go 35.08% <0.00%> (-29.84%) ⬇️
api/internal/core/entity/entity.go 75.00% <0.00%> (-25.00%) ⬇️
api/internal/handler/global_rule/global_rule.go 66.12% <0.00%> (-17.75%) ⬇️
api/internal/utils/utils.go 54.11% <0.00%> (-11.77%) ⬇️
api/internal/route.go 77.14% <0.00%> (-8.58%) ⬇️
api/internal/core/store/storehub.go 67.28% <0.00%> (-3.74%) ⬇️
api/internal/core/storage/etcd.go 43.63% <0.00%> (-3.64%) ⬇️
api/internal/filter/schema.go 52.10% <0.00%> (-3.37%) ⬇️
api/internal/core/store/validate.go 67.03% <0.00%> (-2.24%) ⬇️
api/internal/handler/label/label.go 80.18% <0.00%> (-1.89%) ⬇️
... and 86 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cb4b43...df804ce. Read the comment docs.

@Jaycean Jaycean requested a review from starsz March 15, 2021 02:24
@imjoey imjoey merged commit f88a657 into apache:master Mar 16, 2021
@Jaycean Jaycean deleted the rewrite-e2e-test-route-with-priority-test-with-ginkgo branch March 18, 2021 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants