Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add plugin template config feature #1540

Merged
merged 41 commits into from
Mar 5, 2021

Conversation

LiteSun
Copy link
Member

@LiteSun LiteSun commented Mar 2, 2021

Please answer these questions before submitting a pull request


@codecov-io
Copy link

codecov-io commented Mar 2, 2021

Codecov Report

Merging #1540 (71b8e87) into master (77b42e8) will decrease coverage by 14.72%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1540       +/-   ##
===========================================
- Coverage   70.22%   55.49%   -14.73%     
===========================================
  Files         130       49       -81     
  Lines        5340     3164     -2176     
  Branches      549        0      -549     
===========================================
- Hits         3750     1756     -1994     
+ Misses       1342     1104      -238     
- Partials      248      304       +56     
Flag Coverage Δ
backend-e2e-test 55.49% <ø> (-0.19%) ⬇️
backend-e2e-test-ginkgo 39.79% <ø> (-0.13%) ⬇️
backend-unit-test ?
frontend-e2e-test ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/internal/core/store/query.go 0.00% <0.00%> (-88.10%) ⬇️
api/internal/core/store/selector.go 0.00% <0.00%> (-75.93%) ⬇️
api/internal/handler/plugin/plugin.go 15.15% <0.00%> (-72.73%) ⬇️
api/internal/utils/runtime/runtime.go 0.00% <0.00%> (-64.29%) ⬇️
api/internal/core/store/validate_mock.go 0.00% <0.00%> (-50.00%) ⬇️
api/internal/handler/service/service.go 57.44% <0.00%> (-34.05%) ⬇️
api/internal/handler/ssl/ssl.go 38.46% <0.00%> (-30.77%) ⬇️
api/internal/core/store/store.go 57.22% <0.00%> (-30.73%) ⬇️
api/internal/filter/authentication.go 41.66% <0.00%> (-30.56%) ⬇️
api/internal/filter/ip_filter.go 48.71% <0.00%> (-23.08%) ⬇️
... and 85 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77b42e8...71b8e87. Read the comment docs.

@LiteSun LiteSun changed the title wip: Plugn template config feat: add plugin template config feature Mar 4, 2021
@LiteSun LiteSun marked this pull request as ready for review March 4, 2021 04:03
@LiteSun LiteSun requested a review from juzhiyuan March 4, 2021 04:03
web/config/routes.ts Outdated Show resolved Hide resolved
web/config/routes.ts Outdated Show resolved Hide resolved
web/src/components/LabelsfDrawer/LabelsDrawer.tsx Outdated Show resolved Hide resolved
web/src/components/Plugin/locales/en-US.ts Outdated Show resolved Hide resolved
web/src/components/Plugin/locales/en-US.ts Outdated Show resolved Hide resolved
web/src/components/Plugin/locales/zh-CN.ts Outdated Show resolved Hide resolved
web/src/components/Plugin/locales/zh-CN.ts Outdated Show resolved Hide resolved
web/src/pages/PluginTemplate/Create.tsx Outdated Show resolved Hide resolved
@liuxiran
Copy link
Contributor

liuxiran commented Mar 4, 2021

LGTM expect that

<PluginPage initialData={rest.step3Data.plugins} readonly />
also need to support select plugin template configuration

@LiteSun
Copy link
Member Author

LiteSun commented Mar 4, 2021

LGTM expect that

<PluginPage initialData={rest.step3Data.plugins} readonly />

also need to support select plugin template configuration

good catch!

@LiteSun
Copy link
Member Author

LiteSun commented Mar 4, 2021

<PluginPage initialData={rest.step3Data.plugins} readonly />

also need to support select plugin template configuration

updated

@LiteSun LiteSun requested review from liuxiran and bzp2010 March 4, 2021 15:47
@liuxiran
Copy link
Contributor

liuxiran commented Mar 4, 2021

<PluginPage initialData={rest.step3Data.plugins} readonly />

also need to support select plugin template configuration

updated

LGTM👍, it seems that there are some thing wrong with Ci , maybe it need to force push to rerun.
and it would be better to add a test case to test for the content of step4 after pr merged thanks

@LiteSun LiteSun merged commit 938b2b9 into apache:master Mar 5, 2021
@LiteSun LiteSun deleted the plugn-template-config branch March 5, 2021 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants