Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Press Enter key can trigger the Login button #1472

Merged
merged 7 commits into from
Feb 18, 2021
Merged

feat: Press Enter key can trigger the Login button #1472

merged 7 commits into from
Feb 18, 2021

Conversation

guoqqqi
Copy link
Member

@guoqqqi guoqqqi commented Feb 13, 2021

Please answer these questions before submitting a pull request


New feature or improvement

  • Describe the details and related test reports.
    You can press Enter to log in.

Copy link
Member

@juzhiyuan juzhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And add the test case when the Enter key is pressed.

@codecov-io
Copy link

codecov-io commented Feb 14, 2021

Codecov Report

Merging #1472 (66dd287) into master (1804c75) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1472      +/-   ##
==========================================
+ Coverage   68.66%   68.69%   +0.03%     
==========================================
  Files          48       48              
  Lines        3038     3038              
==========================================
+ Hits         2086     2087       +1     
+ Misses        713      712       -1     
  Partials      239      239              
Impacted Files Coverage Δ
api/internal/core/store/store.go 87.95% <0.00%> (+0.60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1804c75...66dd287. Read the comment docs.

web/cypress/integration/user/login.spec.js Outdated Show resolved Hide resolved
web/cypress/integration/user/login.spec.js Outdated Show resolved Hide resolved
web/cypress/integration/user/login.spec.js Outdated Show resolved Hide resolved
web/cypress/fixtures/data.json Outdated Show resolved Hide resolved
web/cypress/fixtures/data.json Outdated Show resolved Hide resolved
@juzhiyuan
Copy link
Member

Hi, please sync your codes with the master branch to fix the CI failure.

@juzhiyuan juzhiyuan merged commit adda38b into apache:master Feb 18, 2021
@juzhiyuan juzhiyuan deleted the login-enter branch February 18, 2021 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(fe): Press Enter key can trigger the Login button
6 participants