fix: Add version ldflags for building manager-api in Dockerfile

[imjoey]

Signed-off-by: imjoey [email protected]

Please answer these questions before submitting a pull request

• Why submit this pull request?

• Bugfix

• New feature provided

• Improve performance

• Backport patches

• Related issues

Fixes #1350 .

---

Bugfix

• Description

At previous manager-api build phase in Dockerfile, the ldflags of github.com/apisix/manager-api/cmd.Version and github.com/apisix/manager-api/cmd.GitHash are missing. This lead to the no Version output when running manager-api, as described in #1350 .

• How to fix?

Add missing ldflags in Dockerfile. For simplicity, this PR is going to reuse the existing built script ./api/build.sh to compile out the binary.

In addition, this PR will also reduce the usage of RUN commands for smaller image size.

• Additional

FYI, since there is no .githash or .git/ within the artifact downloaded from Github , the GitHash output is still missing.

[imjoey]

ping @nic-chen @starsz @moonming for reviewing. Thanks.

[nic-chen]

@imjoey thanks
we could run test for it，please refer https://github.com/apache/apisix-dashboard/blob/master/.github/workflows/deploy-with-docker.yml
but don't push the image

[codecov-io]

Codecov Report

Merging #1393 (2aa8dd8) into master (619165a) will increase coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1393      +/-   ##
==========================================
+ Coverage   65.73%   65.87%   +0.13%     
==========================================
  Files          44       44              
  Lines        2948     2948              
==========================================
+ Hits         1938     1942       +4     
+ Misses        781      774       -7     
- Partials      229      232       +3     

Impacted Files	Coverage Δ
api/internal/utils/closer.go	33.33% <0.00%> (ø)
api/internal/core/storage/etcd.go	48.48% <0.00%> (ø)
api/cmd/managerapi.go	60.29% <0.00%> (+5.88%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 619165a...2aa8dd8. Read the comment docs.

[imjoey]

@imjoey thanks
we could run test for it，please refer https://github.com/apache/apisix-dashboard/blob/master/.github/workflows/deploy-with-docker.yml
but don't push the image

@nic-chen thanks for the direction. An additional CI test triggered on pull request is added for docker testing. Any feedback is welcome.

[nic-chen]

@imjoey thanks
we could run test for it，please refer https://github.com/apache/apisix-dashboard/blob/master/.github/workflows/deploy-with-docker.yml
but don't push the image

@nic-chen thanks for the direction. An additional CI test triggered on pull request is added for docker testing. Any feedback is welcome.

well done! thanks.