Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: spelling #1002

Merged
merged 1 commit into from
Dec 10, 2020
Merged

fix: spelling #1002

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ Please refer to the [User Guide](./docs/USER_GUIDE.md).

## Contributing

Please refer to the [Contribution Guide](./CONTRIBUTING.md) for a more detailed infomation.
Please refer to the [Contribution Guide](./CONTRIBUTING.md) for a more detailed information.

## FAQ

Expand Down
10 changes: 5 additions & 5 deletions api/conf/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3217,21 +3217,21 @@
"minProperties": 1,
"properties": {
"body": {
"description": "new body for repsonse",
"description": "new body for response",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to update the schema of APISIX too

@jbampton how did you find those problems? Any tools?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @membphis I use various tools like linters, spell checkers and also the find and replace function in my editor 👍

"type": "string"
},
"body_base64": {
"default": false,
"description": "whether new body for repsonse need base64 decode before return",
"description": "whether new body for response need base64 decode before return",
"type": "boolean"
},
"headers": {
"description": "new headers for repsonse",
"description": "new headers for response",
"minProperties": 1,
"type": "object"
},
"status_code": {
"description": "new status code for repsonse",
"description": "new status code for response",
"maximum": 598,
"minimum": 200,
"type": "integer"
Expand Down Expand Up @@ -3582,7 +3582,7 @@
"type": "number"
},
"server_addr": {
"description": "default is $server_addr, you can speific your external ip address",
"description": "default is $server_addr, you can specify your external ip address",
"pattern": "^[0-9]{1,3}.[0-9]{1,3}.[0-9]{1,3}.[0-9]{1,3}$",
"type": "string"
},
Expand Down
2 changes: 1 addition & 1 deletion api/test/e2e/route_with_priority_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ func TestRoute_with_priority(t *testing.T) {
ExpectStatus: http.StatusOK,
},
{
caseDesc: "access the route to determine whether it meets the priority (compair 1 and default)",
caseDesc: "access the route to determine whether it meets the priority (compare 1 and default)",
Object: APISIXExpect(t),
Method: http.MethodGet,
Path: "/server_port",
Expand Down
2 changes: 1 addition & 1 deletion web/src/global.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ if (pwa) {
};
worker.postMessage({ type: 'skip-waiting' }, [channel.port2]);
});
// Refresh current page to use the updated HTML and other assets after SW has skiped waiting
// Refresh current page to use the updated HTML and other assets after SW has skipped waiting
window.location.reload(true);
return true;
};
Expand Down
4 changes: 2 additions & 2 deletions web/src/locales/en-US/component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,13 @@ export default {
'component.status.success': 'Successfully',
'component.status.fail': 'Failed',
'component.global.popconfirm.title.delete': 'Are you sure to delete this record ?',
'component.global.notification.success.messaage.deleteSuccess': 'Deleted Successfully',
'component.global.notification.success.message.deleteSuccess': 'Deleted Successfully',

'component.global.steps.stepTitle.basicInformation': 'Basic Information',
'component.global.steps.stepTitle.preview': 'Preview',
'component.global.steps.stepTitle.pluginConfig': 'Plugin Config',

'component.global.pleaseEnter': 'Please Eneter',
'component.global.pleaseEnter': 'Please Enter',
'component.global.pleaseChoose': 'Please Choose',
'component.global.pleaseCheck': 'Please Check',

Expand Down
2 changes: 1 addition & 1 deletion web/src/locales/en-US/globalHeader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export default {
'component.globalHeader.notification': 'Notification',
'component.globalHeader.notification.empty': 'You have viewed all notifications.',
'component.globalHeader.message': 'Message',
'component.globalHeader.message.empty': 'You have viewed all messsages.',
'component.globalHeader.message.empty': 'You have viewed all messages.',
'component.globalHeader.event': 'Event',
'component.globalHeader.event.empty': 'You have viewed all events.',
'component.noticeIcon.clear': 'Clear',
Expand Down
2 changes: 1 addition & 1 deletion web/src/pages/Route/locales/en-US.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ export default {
'page.route.select.option.configCustom': 'Custom',
'page.route.select.option.forbidden': 'Forbidden',
'page.route.form.itemLabel.redirectCustom': 'Custom Redirect',
'page.route.input.placeholder.redirectCustom': 'For examle: /foo/index.html',
'page.route.input.placeholder.redirectCustom': 'For example: /foo/index.html',
'page.route.select.option.redirect301': '301(Permanent Redirect)',
'page.route.select.option.redirect302': '302(Temporary Redirect)',

Expand Down
2 changes: 1 addition & 1 deletion web/src/pages/Route/typing.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ declare namespace RouteModule {
status: boolean;
};

type AvancedMatchingRules = {
type AdvancedMatchingRules = {
advancedMatchingRules: MatchingRule[];
};

Expand Down