Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The API for fetching all plugins should return disable property #1227

Closed
juzhiyuan opened this issue Jan 7, 2021 · 8 comments · Fixed by apache/apisix#3272 or #1301
Closed

The API for fetching all plugins should return disable property #1227

juzhiyuan opened this issue Jan 7, 2021 · 8 comments · Fixed by apache/apisix#3272 or #1301
Labels
Milestone

Comments

@juzhiyuan
Copy link
Member

Feature request

Please describe your feature

The data from plugins?all=true, only part of the data contains a disable property, so the FE has to hack codes.

https://github.com/apache/apisix-dashboard/blob/master/web/src/components/Plugin/PluginDetail.tsx#L62-L74

@juzhiyuan juzhiyuan added this to the 2.4 milestone Jan 7, 2021
@juzhiyuan
Copy link
Member Author

cc @nic-chen

High Priority

@nic-chen
Copy link
Member

Add the disable attribute to the schema of all plugins? Or should the manager api do this hack? What is your opinion? Thanks. @juzhiyuan

What do you think is better? Thanks. @membphis @spacewander

@juzhiyuan
Copy link
Member Author

Because I see that a part of plugins have that property, and others don't have :( little curious

@spacewander
Copy link
Member

@juzhiyuan
It is expected that the property is injected into each plugin. Which plugins have that property and which don't?

@juzhiyuan
Copy link
Member Author

juzhiyuan commented Jan 13, 2021

apisix/admin/plugins?all=true

image

image

@juzhiyuan
Copy link
Member Author

@nic-chen anything we need to do for this issue?

@nic-chen
Copy link
Member

@nic-chen anything we need to do for this issue?

oh, we need to sync the schema to dashboard since the PR has been merged.

@juzhiyuan juzhiyuan reopened this Jan 14, 2021
@juzhiyuan
Copy link
Member Author

ok, reop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants