fix(ui): route plugins register failed #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ourai
force-pushed
the
wallet-connector-plugin
branch
from
2488f58 to
b89d021
Compare
|
@ourai Hello, thank you for sharing. It gave me inspiration. I refactored the internal logic of PluginKit. There is no need to introduce Event at present, so I removed it. At present, I only need to modify the loading style. |
robinv8
reviewed
Oct 22, 2024
robinv8
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I'm working on developing a
routeStandard UI Plugin.When I try to debug with back-end services, I found that my plugin registered failed.
The reason is that execution order is wrong, just like below:
The function that merge dynamic routes into pre-defined routes should be executed after the HTTP request was done.
So, I make the initialization of router as "lazy" mode.