Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix] Spark k8s optimizer release error #3402

Merged

Conversation

lintingbin
Copy link
Contributor

Why are the changes needed?

Close #3401.

Brief change log

  • When building the Spark config, a step was added to merge the resource group attributes to prevent the configuration of spark.kubernetes.namespace from not taking effect on the resource group.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? no

@github-actions github-actions bot added the module:ams-server Ams server module label Jan 9, 2025
@tcodehuber
Copy link
Contributor

@lintingbin Thanks for your contribution!

@tcodehuber tcodehuber changed the title fix: spark k8s optimizer release error [Hotfix] Spark k8s optimizer release error Jan 15, 2025
@tcodehuber tcodehuber merged commit 0678ba0 into apache:master Jan 15, 2025
4 checks passed
zhoujinsong pushed a commit to zhoujinsong/amoro that referenced this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:ams-server Ams server module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: k8s spark optimizer release error
3 participants