[AMORO-3352]Add mysql-connector-j dependency by maven profile #3380
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3380 +/- ##
============================================
+ Coverage 21.59% 21.62% +0.03%
- Complexity 2309 2313 +4
============================================
Files 426 426
Lines 39719 39724 +5
Branches 5624 5623 -1
============================================
+ Hits 8577 8591 +14
+ Misses 30414 30406 -8
+ Partials 728 727 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pom.xml
Outdated
| @@ -151,10 +151,12 @@ | |||
| <guava.version>32.1.1-jre</guava.version> | |||
| <hudi.version>0.14.1</hudi.version> | |||
| <pagehelper.version>6.1.0</pagehelper.version> | |||
| <mysql-connector-j.version>8.1.0</mysql-connector-j.version> | |||
There was a problem hiding this comment.
bump to latest version to fix CVE
There was a problem hiding this comment.
Thank you very much for your advice, I have already fixed it, and I also wish you a happy New Year.
zhangwl9
force-pushed
the
AMORO-add-mysql-dependency
branch
from
fe94914 to
b84ab00
Compare
There was a problem hiding this comment.
LGTM, We will not include MySQL dependency when releasing amoro, so there is no Lincese problem here.
In addition, this will have some other benefits, such as by turning on the profile to include MySQL dependency when developing and testing locally, and when releasing the version within the company
Lets see if there is any comments from the community.
Why are the changes needed?
Close #3352.
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation