[AMORO-3235] Support action filter by ams backend #3236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
majin1102
changed the title
zhoujinsong
requested changes
Oct 11, 2024
There was a problem hiding this comment.
@majin1102 I got some error when trying to validate this PR in my local environment.
| /** Get optimize tables. * @return List of {@link TableOptimizingInfo} */ | ||
| public void getOptimizerTables(Context ctx) { | ||
| String optimizerGroup = ctx.pathParam("optimizerGroup"); | ||
| String dbFilterStr = ctx.queryParam("dbSearchInput"); | ||
| String tableFilterStr = ctx.queryParam("tableSearchInput"); | ||
| String[] requestedActions = ctx.queryParamAsClass("actions", String[].class).getOrDefault(null); |
There was a problem hiding this comment.
I got following information when trying to ran this PR in my local environment, It seems Javalin cannot parse string array param by default.
[JettyServerThreadPool-44] [io.javalin.Javalin] [] - Can't convert to String[]. Register a converter using JavalinValidation#register.
There was a problem hiding this comment.
Sorry for that.
I have tested the new code, PTAL
To be reviewed |
baiyangtx
approved these changes
Oct 14, 2024
zhoujinsong
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Close #3235.
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation