[AMORO-2875] Added metric for orphan file action #3004
Conversation
github-actions
bot
added
type:docs
huyuanfeng2018
force-pushed
the
amoro-2875
branch
from
d03922e to
061e1f1
Compare
docs/user-guides/metrics.md
Outdated
| | table_slated_orphan_content_file_cleaning_count | Counter | catalog, database, table | Slated Count of orphan content files cleaned in the table since ams started | | ||
| | table_slated_orphan_metadata_file_cleaning_count | Counter | catalog, database, table | Slated Count of orphan metadata files cleaned in the table since ams started | |
There was a problem hiding this comment.
What does slated_orphan_content_file and slated_orpha_metadata_file means?
There was a problem hiding this comment.
Indicates the calculated number of files expected to be deleted. Failure may occur during the deletion process, so there will also be an metric of the actual number of deleted files.
|
https://iceberg.apache.org/docs/nightly/spark-procedures/#output_7 |
|
Hi， @huyuanfeng2018 |
| } | ||
|
|
||
| public static final MetricDefine TABLE_ORPHAN_CONTENT_FILE_CLEANING_COUNT = | ||
| defineCounter("table_orphan_content_cleaning_count") |
There was a problem hiding this comment.
Is table_orphan_content_file_cleaning_count proper here, being consistent with the table_orphan_metadata_file_cleanning_count ?
There was a problem hiding this comment.
Well, there was a mistake here, it's been fixed
| .build(); | ||
|
|
||
| public static final MetricDefine TABLE_SLATED_ORPHAN_CONTENT_FILE_CLEANING_COUNT = | ||
| defineCounter("table_slated_orphan_content_file_cleaning_count") |
There was a problem hiding this comment.
Is the name table_expected_orphan_content_file_cleaning_count easier to understand here?
There was a problem hiding this comment.
I originally inherited the style of the old code and named it slated, but now it seems expected is easier to understand.
huyuanfeng2018
force-pushed
the
amoro-2875
branch
from
8542efa to
8f7f213
Compare
|
@huyuanfeng2018 Some conflicts seem to need to be fixed. |
# Conflicts: # amoro-ams/amoro-ams-server/src/main/java/org/apache/amoro/server/table/TableRuntime.java
fixed & PTAL. |
Why are the changes needed?
Close #2875
Brief change log
TableOrphanFilesCleaningMetricsused to collect metrics generated by cleaning orphan filesHow was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation