Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix] Fix wrong usage of Preconditions #2829

Merged
merged 1 commit into from
May 12, 2024
Merged

Conversation

link3280
Copy link
Contributor

Why are the changes needed?

As titled.

Brief change log

  • Fix wrong usage of Preconditions

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@codecov-commenter
Copy link

codecov-commenter commented May 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.79%. Comparing base (a9a624f) to head (7a12b95).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2829      +/-   ##
============================================
- Coverage     35.96%   32.79%   -3.17%     
- Complexity      386     3823    +3437     
============================================
  Files            46      558     +512     
  Lines          4708    46296   +41588     
  Branches        513     6177    +5664     
============================================
+ Hits           1693    15182   +13489     
- Misses         2847    29921   +27074     
- Partials        168     1193    +1025     
Flag Coverage Δ
core 32.79% <100.00%> (?)
trino ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@shidayang shidayang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shidayang shidayang merged commit eabf74e into apache:master May 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants