Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update dashboard readme #1984

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Conversation

minteliuwm
Copy link
Contributor

Why are the changes needed?

Brief change log

  • update dashboard readme doc

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions bot added the module:ams-dashboard Ams dashboard module label Sep 17, 2023
@codecov
Copy link

codecov bot commented Sep 17, 2023

Codecov Report

Patch has no changes to coverable lines.

📢 Thoughts on this report? Let us know!.

@shidayang
Copy link
Contributor

@YesOrNo828 cc. Flink ci occasionally fails to pass

@shidayang
Copy link
Contributor

Thanks for your contributions. This pr LGTM

Copy link
Contributor

@baiyangtx baiyangtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

Thanks a lot for your contribution.

ams/dashboard/README.md Outdated Show resolved Hide resolved
ams/dashboard/README.md Outdated Show resolved Hide resolved
ams/dashboard/README.md Outdated Show resolved Hide resolved
ams/dashboard/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zhoujinsong zhoujinsong merged commit dae3294 into apache:master Sep 18, 2023
@wangtaohz wangtaohz mentioned this pull request Sep 20, 2023
56 tasks
ShawHee pushed a commit to ShawHee/arctic that referenced this pull request Dec 29, 2023
* doc: update dashboard readme

* doc: update dashboard readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:ams-dashboard Ams dashboard module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants