Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement]: Add Paimon Table Consumer Infos In Ams Dashboard #3054

Closed
2 of 3 tasks
Tracked by #3048
czy006 opened this issue Jul 23, 2024 · 4 comments · Fixed by #3081
Closed
2 of 3 tasks
Tracked by #3048

[Improvement]: Add Paimon Table Consumer Infos In Ams Dashboard #3054

czy006 opened this issue Jul 23, 2024 · 4 comments · Fixed by #3081
Assignees
@Liammcl
Labels
module:ams-dashboard Ams dashboard module type:improvement
Milestone
Release 0.8.0

Comments

@czy006
Copy link
Contributor

czy006 commented Jul 23, 2024

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

after #3027 for paimon consumer,we need dashboard have some consumer info to know consumer paimon table what next snapshot

How should we improve?

image

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Subtasks

No response

Code of Conduct
@Liammcl
Copy link
Contributor

Liammcl commented Jul 23, 2024

I am willing to submit this PR

@czy006 czy006 added this to the Release 0.8.0 milestone Jul 23, 2024
@czy006 czy006 mentioned this issue Jul 31, 2024
Merged
3 tasks
Liammcl added a commit to Liammcl/amoro that referenced this issue Aug 7, 2024
@Liammcl
[amoro-apache#3054]: Add Paimon Table Consumer Infos In Ams Dashboard
c406b92
@Liammcl Liammcl mentioned this issue Aug 7, 2024
Merged
3 tasks
@zhoujinsong
Copy link
Contributor

Hi, I am not sure about placing the consumer information with the branch and tag is a good suggestion.

Consumer information appears to be completely new metadata, perhaps we can consider adding an additional TAB to display it. Alternatively, if it is closely related to the snapshot, we could also consider highlighting it in the snapshot list.

@Liammcl
Copy link
Contributor

Liammcl commented Aug 8, 2024

sure, Where do you think it should be placed ?

czy006 added a commit that referenced this issue Aug 12, 2024
@Liammcl @czy006
[Improvement]: Add Paimon Table Consumer Infos In Ams Dashboard (#3081)
22b7e35 
* 合并缓存

* [Improvement]: Add Paimon Table Consumer Infos In Ams Dashboard

* [Improvement]: Add Paimon Table Consumer Infos In Ams Dashboard

* [amoro-#3054]: Add Paimon Table Consumer Infos In Ams Dashboard

* fix proxy

* pnpm-lock rebase

* fix someting wrong

* fixed

* fied

* fixed

* fixed

* fix:Code formatting issue

* fix bugs

* fixed bug

* fix: change typescript consumers to consumer

---------

Co-authored-by: ConradJam <[email protected]>
@czy006
Copy link
Contributor Author

czy006 commented Aug 12, 2024

Hi, I am not sure about placing the consumer information with the branch and tag is a good suggestion.

Consumer information appears to be completely new metadata, perhaps we can consider adding an additional TAB to display it. Alternatively, if it is closely related to the snapshot, we could also consider highlighting it in the snapshot list.

In this section, you can view the final rendering, which is part of the Snapshot metadata, and if there is a better place to display it, we can modify it at any time cc @zhoujinsong

@Aireed Aireed mentioned this issue Dec 4, 2024
Open
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Liammcl Liammcl

Labels
module:ams-dashboard Ams dashboard module type:improvement
Projects
None yet
Milestone
Release 0.8.0
Development

Successfully merging a pull request may close this issue.

[Improvement]: Add Paimon Table Consumer Infos In Ams Dashboard Liammcl/amoro
3 participants
@zhoujinsong @czy006 @Liammcl