Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Subtask]: Replace deperated classes under ams.server by classes of ams.api #2665

Closed
3 tasks done
majin1102 opened this issue Mar 23, 2024 · 0 comments · Fixed by #2666
Closed
3 tasks done

[Subtask]: Replace deperated classes under ams.server by classes of ams.api #2665

majin1102 opened this issue Mar 23, 2024 · 0 comments · Fixed by #2666
Labels
type:subtask Subtask of another issue

Comments

@majin1102
Copy link
Contributor

Search before asking

  • I have searched in the issues and found no similar issues.

Description

Including:

  1. ServerIdentifier
  2. StateField
  3. TableConfiguration(and other Configuration classes)

Parent issue

#2596

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct
@majin1102 majin1102 added the type:subtask Subtask of another issue label Mar 23, 2024
majin1102 added a commit to majin1102/amoro that referenced this issue Mar 23, 2024
@majin1102
resolve apache#2665
c502e98
@majin1102 majin1102 mentioned this issue Mar 23, 2024
Merged
3 tasks
zhoujinsong added a commit that referenced this issue Mar 26, 2024
@majin1102 @zhoujinsong
[AMORO-2665] Replace deperated classes under ams.server by classes of…
e610bca 
… ams.api (#2666)

* resolve #2665

* fix compiler errors

* fix compiler errors

* spotless apply

* fix compiler error

* follow suggestions

* resolve conflicts with master

* spotless apply

* fix @VisibleForTesting

* remove some illegal imports

* Add @JsonIgnoreProperties(ignoreUnknown = true)

* fix com.google.common reference

---------

Co-authored-by: ZhouJinsong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:subtask Subtask of another issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[AMORO-2665] Replace deperated classes under ams.server by classes of ams.api majin1102/amoro
1 participant
@majin1102