-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-9347] Fix QuboleHook unable to add list to tags #9349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
|
egibbm
changed the title
[#9347] Fix QuboleHook unable to add list to tags
[AIRFLOW-9347] Fix QuboleHook unable to add list to tags
Jun 17, 2020
egibbm
force-pushed
the
9347-qubolehooks-tags-list
branch
from
June 17, 2020 14:52
07bca5a
to
d2782db
Compare
egibbm
force-pushed
the
9347-qubolehooks-tags-list
branch
from
June 17, 2020 15:12
d2782db
to
d48ea0a
Compare
chattarajoy
approved these changes
Jun 22, 2020
thanks for taking this up @egibbm . LGTM |
msumit
reviewed
Jun 22, 2020
msumit
approved these changes
Jun 24, 2020
Awesome work, congrats on your first merged pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon upgrading to 1.10.10, existing behavior of accepting a list of tags in QuboleOperator() dag have broken due to a refactor. This fix should have the same behavior of handling tags as expected before the refactor.
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.