[AIRFLOW-6040] ReadTimeoutError should not raise exception #7616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:Scheduler
|
continuation of #6643 |
dimberman
changed the title
dimberman
changed the title
dimberman
force-pushed
the
AIRFLOW_6040-handle-timeouts
branch
from
a50887d to
5658156
Compare
dimberman
force-pushed
the
AIRFLOW_6040-handle-timeouts
branch
from
5658156 to
6f61cdb
Compare
ashb
approved these changes
Mar 3, 2020
kaxil
approved these changes
Mar 4, 2020
2 tasks
|
@dimberman I do not fully agree with making this a warning. Warnings often confuse people and this read timeout is totally expected. I would even demote it to debug because we would only look into this if something is fishy anyways. |
kaxil
pushed a commit
that referenced
this pull request
Mar 4, 2020
|
I don't think this is the right approach for fixing AIRFLOW-6040. The Watcher isn't being ran in its own thread so it must timeout so it's not blocking further execution. Therefor it's not an error or a warning as this is the expected behavior you're looking for. |
galuszkak
pushed a commit
to FlyrInc/apache-airflow
that referenced
this pull request
Mar 5, 2020
|
@maxirus While I agree with this being the wrong approach to fix the issue, I beg to differ: Yes, it is not run in a separate thread. But it is run in a separate process. |
kaxil
pushed a commit
that referenced
this pull request
Mar 19, 2020
kaxil
pushed a commit
to astronomer/airflow
that referenced
this pull request
Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link: AIRFLOW-6040
Make sure to mark the boxes below before creating PR: [x]
[AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX].In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.