Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5597] Linkify urls in task instance log #6265

Merged
merged 1 commit into from
Oct 8, 2019

Conversation

ZxMYS
Copy link
Contributor

@ZxMYS ZxMYS commented Oct 5, 2019

#6070 # Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:
    Very often we have urls in our task instances' logs. This change allows these urls to be rendered as clickable links, so users no longer have to copy and paste these urls manually.
    image

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    Just a simple JS change

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.

@ZxMYS ZxMYS force-pushed the xzhu/linkify branch 2 times, most recently from c5e8201 to 60f39c8 Compare October 5, 2019 00:41
@ZxMYS ZxMYS marked this pull request as ready for review October 5, 2019 00:42
@ZxMYS ZxMYS force-pushed the xzhu/linkify branch 3 times, most recently from c6fc1ab to 6c52c19 Compare October 5, 2019 00:51
@codecov-io
Copy link

codecov-io commented Oct 5, 2019

Codecov Report

Merging #6265 into master will increase coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6265      +/-   ##
==========================================
+ Coverage   80.09%   80.28%   +0.19%     
==========================================
  Files         612      612              
  Lines       35320    35320              
==========================================
+ Hits        28289    28357      +68     
+ Misses       7031     6963      -68
Impacted Files Coverage Δ
airflow/contrib/operators/ssh_operator.py 82.5% <0%> (-1.25%) ⬇️
airflow/utils/dag_processing.py 56.89% <0%> (+0.34%) ⬆️
airflow/gcp/hooks/mlengine.py 78.63% <0%> (+57.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1347b77...47a53fc. Read the comment docs.

@mik-laj mik-laj added the core:UI label Oct 5, 2019
@mik-laj mik-laj self-requested a review October 5, 2019 02:55
@ZxMYS ZxMYS force-pushed the xzhu/linkify branch 3 times, most recently from 5f28059 to 3dfa709 Compare October 7, 2019 18:07
@ZxMYS
Copy link
Contributor Author

ZxMYS commented Oct 8, 2019

Is there a way to re-run the checks? I don't think the error in travis ci is related to my change.

@mik-laj
Copy link
Member

mik-laj commented Oct 8, 2019

I restarted this Travis's job.

@aoen
Copy link
Contributor

aoen commented Oct 8, 2019

LGTM

@aoen aoen merged commit 55bb579 into apache:master Oct 8, 2019
@ZxMYS ZxMYS deleted the xzhu/linkify branch October 8, 2019 18:38
@ZxMYS
Copy link
Contributor Author

ZxMYS commented Oct 8, 2019

To future readers: feel free to improve the regex. The regex in this commit may have been too strict and limiting (e.g. only checks for http / https links, and not allowing Internationalized Domain Names, etc.)

@mik-laj mik-laj added area:webserver Webserver related Issues and removed area:UI labels Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:webserver Webserver related Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants