-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-5597] Linkify urls in task instance log #6265
Conversation
c5e8201
to
60f39c8
Compare
c6fc1ab
to
6c52c19
Compare
Codecov Report
@@ Coverage Diff @@
## master #6265 +/- ##
==========================================
+ Coverage 80.09% 80.28% +0.19%
==========================================
Files 612 612
Lines 35320 35320
==========================================
+ Hits 28289 28357 +68
+ Misses 7031 6963 -68
Continue to review full report at Codecov.
|
5f28059
to
3dfa709
Compare
Is there a way to re-run the checks? I don't think the error in travis ci is related to my change. |
I restarted this Travis's job. |
LGTM |
To future readers: feel free to improve the regex. The regex in this commit may have been too strict and limiting (e.g. only checks for http / https links, and not allowing Internationalized Domain Names, etc.) |
#6070 # Jira
Description
Very often we have urls in our task instances' logs. This change allows these urls to be rendered as clickable links, so users no longer have to copy and paste these urls manually.
Tests
Just a simple JS change
Commits
Documentation