Changing the default base date of the Tree View #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1055,7 +1055,7 @@ def tree(self): | |||
| num_runs = int(num_runs) if num_runs else 25 | |||
|
|
|||
| if not base_date: | |||
| base_date = dag.latest_execution_date or datetime.now() | |||
| base_date = (dag.latest_execution_date + 2 * dag.schedule_interval) or datetime.now() | |||
There was a problem hiding this comment.
In the case of a new DAG dag.latest_execution_date will be None and this will raise an error, you'll need an if here...
|
@mistercrunch Good catch. Fixed in kerzhner@8f64275. |
mistercrunch
added a commit
that referenced
this pull request
Sep 24, 2015
Changing the default base date of the Tree View
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to solve the following pain points:
In other words, we currently see this:
But this is clearer: