Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore deprecations in gcp automl, translate #45128

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

gopidesupavan
Copy link
Member

https://github.com/apache/airflow/actions/runs/12441141635/job/34737776458


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@gopidesupavan
Copy link
Member Author

Do we really need to ignore these deprecations? or we should remove those deprecated classes? it looks like they have date mentioned target around sept 2025.

@gopidesupavan gopidesupavan added the provider:google Google (including GCP) related issues label Dec 21, 2024
@gopidesupavan gopidesupavan reopened this Dec 21, 2024
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's take a closer look before merging

@potiuk potiuk merged commit cc38a43 into apache:main Dec 21, 2024
74 of 93 checks passed
@potiuk
Copy link
Member

potiuk commented Dec 21, 2024

It's ok - it's September 2025 - so they are fine. My question is more why in the original PR the tests did not fail. I am looking into it.

@gopidesupavan
Copy link
Member Author

It's ok - it's September 2025 - so they are fine. My question is more why in the original PR the tests did not fail. I am looking into it.

ah i see it looks like providers tests not triggered in original pr https://github.com/apache/airflow/actions/runs/12431426634/job/34709142003

@gopidesupavan
Copy link
Member Author

looks like selective checks ignoring some of the file checks conditions. trying to look more..

@potiuk
Copy link
Member

potiuk commented Dec 21, 2024

Fix here #45131

@potiuk
Copy link
Member

potiuk commented Dec 21, 2024

It was a very subtle combination of two bugs - and it's mostly a by-product of having several different folders where provider files come from. Will be simplified in the future when we implement #44511 (I am working on it already - first PRs are coming shortly on that one).

@gopidesupavan gopidesupavan deleted the fix-ci-failures-gcp branch December 21, 2024 16:00
LefterisXefteris pushed a commit to LefterisXefteris/airflow that referenced this pull request Jan 5, 2025
agupta01 pushed a commit to agupta01/airflow that referenced this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants