Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependaboat to check upgrades daily #44966

Merged
merged 5 commits into from
Dec 17, 2024

Conversation

gopidesupavan
Copy link
Member


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@gopidesupavan
Copy link
Member Author

gopidesupavan commented Dec 16, 2024

We can configure if any prefix required in PR title. ?

currently it doesn't support the cron expression, so have given daily.

We have dependency in pre-commit , but unfortunately dependaboat is not supported to bump dependencies in pre-commit.

.github/dependabot.yml Outdated Show resolved Hide resolved
.github/dependabot.yml Outdated Show resolved Hide resolved
.github/dependabot.yml Outdated Show resolved Hide resolved
Co-authored-by: Jens Scheffler <[email protected]>
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1
I say lets merge it and we can test it in real time if it works. Good job!

.github/dependabot.yml Show resolved Hide resolved
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - but added one more comment about adding ./dev/breeze as well.

@jscheffl jscheffl merged commit 50c2c9a into apache:main Dec 17, 2024
39 checks passed
@gopidesupavan
Copy link
Member Author

Thanks for the merge :) was bit of on travel today. it looks like dependaboat already started playing his role. hahah

@gopidesupavan
Copy link
Member Author

@gopidesupavan
Copy link
Member Author

LGTM - but added one more comment about adding ./dev/breeze as well.

Thanks for pointing missed that :)

@gopidesupavan gopidesupavan deleted the add-dependaboat branch December 21, 2024 05:24
LefterisXefteris pushed a commit to LefterisXefteris/airflow that referenced this pull request Jan 5, 2025
* add dependaboat to check upgrades daily

* add task_sdk to dependaboat directories list

* Update .github/dependabot.yml

Co-authored-by: Jens Scheffler <[email protected]>

* Remove quotes

Co-authored-by: Jens Scheffler <[email protected]>

* Update .github/dependabot.yml

---------

Co-authored-by: Jens Scheffler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants